Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): Improve alert evaluation failure message #25790

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

anirudhpillai
Copy link
Contributor

Problem

Alert evaluation failures weren't logging error message to sentry/using wrong email template

Changes

Create new email template for evaluation failure + set tags separately.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Tested locally

@anirudhpillai anirudhpillai requested a review from a team October 24, 2024 13:41
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thmsobrmlr thmsobrmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Size Change: 0 B

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.15 MB

compressed-size-action

@anirudhpillai anirudhpillai enabled auto-merge (squash) November 6, 2024 14:09
@anirudhpillai anirudhpillai merged commit 8408fff into master Nov 6, 2024
96 checks passed
@anirudhpillai anirudhpillai deleted the fix/alert-evaluation-failed-message branch November 6, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants